Skip to content

Change release archive check to warning - #57688

Merged
jmagman merged 1 commit into
flutter:masterfrom
jmagman:archive-warning
May 27, 2020
Merged

jmagman merged 1 commit into
flutter:masterfrom
jmagman:archive-warning

Conversation

@jmagman

@jmagman jmagman commented May 20, 2020

Copy link
Copy Markdown
Member

Description

I believe we've tracked down most of the issues related to accidentally archiving with a Debug version of Flutter. Switch the error to a warning to accommodate users who want to distribute Debug versions to QA, etc.

echoing the message with a warning: prefix makes it a real Xcode warning.

Before:
Screen Shot 2020-05-20 at 12 41 53 PM
After:
Screen Shot 2020-05-20 at 12 55 22 PM
Screen Shot 2020-05-20 at 12 55 14 PM

Related Issues

Fixes #57557.

Tests

We don't archive anywhere, not sure how to test this...

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman self-assigned this May 20, 2020
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 20, 2020

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
jmagman merged commit 43f18f3 into flutter:master May 27, 2020
@jmagman
jmagman deleted the archive-warning branch May 27, 2020 17:08
@jmagman jmagman added the platform-ios iOS applications specifically label Aug 21, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Xcode archive builds to be run in Debug and Profile build mode for testing

4 participants