Skip to content

Add FittedBox - #6029

Merged
abarth merged 1 commit into
flutter:masterfrom
abarth:fitted_box
Sep 24, 2016
Merged

abarth merged 1 commit into
flutter:masterfrom
abarth:fitted_box

Conversation

@abarth

@abarth abarth commented Sep 23, 2016

Copy link
Copy Markdown
Contributor

This widget lets you apply an ImageFit to a child widget.

Fixes #5830

@abarth

abarth commented Sep 23, 2016

Copy link
Copy Markdown
Contributor Author

@Hixie

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constrainSizeAndAttemptToPreseveAspectRatio -> constrainSizeAndAttemptToPreserveAspectRatio

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retruned -> returned

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I don't understand bullet three. Do you mean "The returned size as big as possible while still being equal to or smaller than the given size"?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these constraints

@Hixie

Hixie commented Sep 23, 2016

Copy link
Copy Markdown
Contributor

LGTM

This widget lets you apply an ImageFit to a child widget.

Fixes flutter#5830
@abarth
abarth merged commit c27b03b into flutter:master Sep 24, 2016
@abarth
abarth deleted the fitted_box branch September 24, 2016 00:40
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a widget that applies an ImageFit type to its child widget

2 participants