Repository navigation
Conversation
Contributor
Author
We need to pass a WidgetBuilder instead of a Widget to showDrawer so that app-level setStates will trigger a rebuild of the drawer. This patch pulled a refactoring of the global settings in the stocks app so that they were cleanly owned by the StocksApp and referenced by pointer instead of from copies. Fixes flutter#604 Fixes flutter#187
abarth
force-pushed
the
stateful_drawer
branch
from
November 27, 2015 07:07
f14d6df to
7f5c881
Compare
Contributor
There was a problem hiding this comment.
Put a comment in the callback block explaining what changed.
Contributor
|
Make the drawer in the stock demo have some UI mutate a state that is specific to the stock home state (e.g. color of the FAB). If I read the patch correctly, it won't update right. |
Contributor
Author
That's correct. To make that work, I think I'll need to give the Drawer to the Scaffold so that it will be below the StockHome in the hierarchy. We'll probably want to do that eventually anyway for tablet UI. I'll give it a try here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to pass a WidgetBuilder instead of a Widget to showDrawer so that
app-level setStates will trigger a rebuild of the drawer. This patch pulled a
refactoring of the global settings in the stocks app so that they were cleanly
owned by the StocksApp and referenced by pointer instead of from copies.
Fixes #604
Fixes #187