Skip to content

Persistent bottom sheet should not overlap app bar - #6076

Merged
abarth merged 1 commit into
flutter:masterfrom
abarth:sheet_app_bar
Sep 26, 2016
Merged

abarth merged 1 commit into
flutter:masterfrom
abarth:sheet_app_bar

Conversation

@abarth

@abarth abarth commented Sep 26, 2016

Copy link
Copy Markdown
Contributor

The spec forbids persistent bottom sheets from overlapping the app bar. There
are also some fancy scroll-linked effects that we're supposed to do with
persistent bottom sheets, but those will need to wait for another patch.

Fixes #5143

The spec forbids persistent bottom sheets from overlapping the app bar. There
are also some fancy scroll-linked effects that we're supposed to do with
persistent bottom sheets, but those will need to wait for another patch.

Fixes flutter#5143
@abarth

abarth commented Sep 26, 2016

Copy link
Copy Markdown
Contributor Author

@HansMuller

@dragostis dragostis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@abarth
abarth merged commit 55f48f7 into flutter:master Sep 26, 2016
@abarth
abarth deleted the sheet_app_bar branch September 26, 2016 21:02
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gallery, Landscape: Bottom sheet is too high

2 participants