Repository navigation
Doctor check for libimobiledevice/Xcode compatibility - #6111
Merged
Merged
Conversation
libimobiledevice 1.2.0 is incompatible with Xcode >= 8.0. Since the libimobiledevice tools don't include a --version flag, check for valid exit code on running idevicename, if an iOS device is connected.
Member
Author
|
This attempts to detect the incompatibility between Xcode 8 + libimobiledevice 1.2.0 (current). See #5937 for more info. I don't like this much; if you've got ideas on a better solution, I'd like to hear them. In particular, I'm not keen on suggesting an install from head, but not sure what better alternatives we've got. One option might be to deploy compatible versions in the cache; thoughts on how reasonable that approach might be? |
danrubel
approved these changes
Sep 28, 2016
danrubel
left a comment
danrubel
left a comment
There was a problem hiding this comment.
Agree with your sentiment but I don't have anything better to suggest at the moment. LGTM
Member
Author
|
Alright; filed #6118 to follow up on whether or not it's reasonable to move off libimobiledevice. Landing this in the meantime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libimobiledevice 1.2.0 is incompatible with Xcode >= 8.0. Since the
libimobiledevice tools don't include a --version flag, check for valid
exit code on running idevicename, if an iOS device is connected.