Repository navigation
Conversation
Two weeks ago, for some reason __dir__ was replaced with this File.join thing which is completely broken, as it would create something like this: /Users/work/Documents/Playground/AddToAppBug/my_flutter/.ios/Flutter/Users/work/Documents/Playground/AddToAppBug/my_flutter/.ios/Flutter/App.framework when we wanted this /Users/work/Documents/Playground/AddToAppBug/my_flutter/.ios/Flutter/App.framework So if you are compiling app from fresh state, it would create App.framework in wrong place, "pod install" would not include App.framework in the copy frameworks script, and the finished build would have no App.framework inside. Typically this will occur in builds from CI, but not locally, as people don't clean that often.
flutter-dashboard
Bot
added
the
tool
Member
|
Ah this is probably on the right path. I did see /Users/[name]/... paths being generated. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two weeks ago, for some reason
__dir__was replaced with this File.join thing which is doesn't really work, as it would create something like this:/Users/work/Documents/Playground/AddToAppBug/my_flutter/.ios/Flutter/Users/work/Documents/Playground/AddToAppBug/my_flutter/.ios/Flutter/App.framework
when we wanted this
/Users/work/Documents/Playground/AddToAppBug/my_flutter/.ios/Flutter/App.framework
So if you are compiling app from fresh state, it would not create App.framework where it should, "pod install" would not include App.framework in the copy frameworks script, and the finished build would have no App.framework inside.
Typically this will occur in builds from CI, but not locally, as people don't clean that often.
@jmagman FYI