Skip to content

Default child lists to empty lists - #6592

Merged
abarth merged 1 commit into
flutter:masterfrom
abarth:default_child_list
Oct 31, 2016
Merged

abarth merged 1 commit into
flutter:masterfrom
abarth:default_child_list

Conversation

@abarth

@abarth abarth commented Oct 30, 2016

Copy link
Copy Markdown
Contributor

Fixes #6591

@abarth

abarth commented Oct 30, 2016

Copy link
Copy Markdown
Contributor Author

@Hixie

@Hixie

Hixie commented Oct 30, 2016

Copy link
Copy Markdown
Contributor

Search for _emptyWidgetList in basic.dart. We should presumably replace it with inline const <Widget>[] everywhere it's used too.

LGTM.

Test maybe?

@abarth

abarth commented Oct 31, 2016

Copy link
Copy Markdown
Contributor Author

We should presumably replace it with inline const [] everywhere it's used too.

Ok. I'll do that in a separate patch.

Test maybe?

I guess I could test it... I'm not sure it would be such a valuable test though.

@abarth
abarth force-pushed the default_child_list branch from baa160e to 83a4489 Compare October 31, 2016 02:56
@abarth

abarth commented Oct 31, 2016

Copy link
Copy Markdown
Contributor Author

We should presumably replace it with inline const [] everywhere it's used too.

Ok. I'll do that in a separate patch.

Turns out I did it in this patch because I'm such a great guy.

Test maybe?

I guess I could test it... I'm not sure it would be such a valuable test though.

Alright, I tested that all these classes can be constructed with only required arguments. Turned up a bug (and a doc opportunity), so I guess it was worthwhile. :)

@abarth
abarth force-pushed the default_child_list branch from 83a4489 to faa918f Compare October 31, 2016 02:58
@Hixie

Hixie commented Oct 31, 2016

Copy link
Copy Markdown
Contributor

:-)

@abarth
abarth merged commit 018ab3f into flutter:master Oct 31, 2016
@abarth
abarth deleted the default_child_list branch October 31, 2016 03:10
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ScrollableGrid: Omitting optional 'children' parameter returns broken widget

2 participants