Repository navigation
AOT Android: Don't use integer division instructions. - #6714
Conversation
|
Presumably there is no way for us to test this other than by having a physical pixel device? |
|
Unless we want to start creating device-specific binaries, AOT must use the lowest common denominator. Though for this particular case, it would also work to say one must use an ARM64 binary for the Pixel. |
| '--instructions_blob=$instructionsBlob', | ||
| '--embedder_entry_points_manifest=$vmEntryPointsAndroid', | ||
| '--no-sim-use-hardfp', | ||
| '--no-use-integer-division', // Not supported by the Pixel in 32-bit mode. |
There was a problem hiding this comment.
Currently this is already being done by gen_snapshot's main. But it seems prudent to disable it explicitly in case gen_snapshot's defaults change
|
LGTM |
|
Since we've actually already been doing this through gen_snapshot, it's quite likely this is necessary for other devices as well. |
|
We don't currently build ARM64 binaries for Android, but could start doing so. |
|
Does this fix #6693? |
|
#6693 will be fixed when we roll a Dart runtime with: |
3 participants
@jason-simmons