Repository navigation
[flutter_tools] remove globals from desktop configuration - #67146
Merged
Merged
Conversation
flutter-dashboard
Bot
added
the
tool
jonahwilliams
commented
Oct 2, 2020
| ProtocolDiscovery observatoryDiscovery; | ||
|
|
||
| if (debuggingOptions.debuggingEnabled) { | ||
| // TODO(devoncarew): Remember the forwarding information (so we can later remove the |
Contributor
Author
There was a problem hiding this comment.
This has since been done
Contributor
Author
|
This will take a g3fix to land for real |
jonahwilliams
commented
Oct 2, 2020
| void onAttached(ApplicationPackage package, BuildMode buildMode, Process process) {} | ||
| } | ||
|
|
||
| /// A log reader for desktop applications. |
| ).devices, <Device>[]); | ||
| }); | ||
|
|
||
| testWithoutContext('WindowsDevices lists a devices if the workflow is supported ', () async { |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| testWithoutContext('WindowsDevices lists a devices if the workflow is supported ', () async { | |
| testWithoutContext('WindowsDevices lists a devices if the workflow is supported', () async { |
| Platform: () => windows, | ||
| FeatureFlags: () => TestFeatureFlags(isWindowsEnabled: true), | ||
| }, | ||
| final FakePlatform windows = FakePlatform(operatingSystem: 'windows'); |
Contributor
There was a problem hiding this comment.
And we can safely assume these never get mutated, leaking state between tests?
Contributor
Author
There was a problem hiding this comment.
There are some contrived circumstances where you can mutate the environment field, but only if that is set to a non-const value (it defaults to an empty const map, which is unmodifiable)
christopherfujino
approved these changes
Oct 2, 2020
christopherfujino
left a comment
christopherfujino
left a comment
Contributor
There was a problem hiding this comment.
LGTM with a few nits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors the desktop devices and workflow to remove unnecessary usage of global variables. This should make it easier to test and continue enhancing the desktop functionality of the tooling
#47161