Skip to content

[flutter_tools] add more docs to cocoapods, move to globals - #67237

Merged
jonahwilliams merged 3 commits into
flutter:masterfrom
jonahwilliams:cocoapods_validator
Oct 6, 2020
Merged

jonahwilliams merged 3 commits into
flutter:masterfrom
jonahwilliams:cocoapods_validator

Conversation

@jonahwilliams

@jonahwilliams jonahwilliams commented Oct 3, 2020 •

Copy link
Copy Markdown
Contributor

Description

Add some placeholder docs to the Cocoapods validator and Cocoapods class. Add the injected validator to globals.

#47161

@flutter-dashboard flutter-dashboard Bot added tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Oct 3, 2020
@jonahwilliams
jonahwilliams marked this pull request as ready for review October 5, 2020 15:32
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jonahwilliams
jonahwilliams requested review from jmagman and removed request for jmagman October 5, 2020 18:17

/// Cocoapods is a depenency management solution for iOS and macOS applications.
///
/// Cocoapods is generally installed via homebrew and interacted with via

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, i think the homebrew formula for cocoapods just delegates to rubygems anyway

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL, why did I install it with brew - perhaps that was old documentation?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, and added link to iOS getting started docs

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit about s/homebrew/rubygems/, otherwise lgtm

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams
jonahwilliams merged commit 2474b07 into flutter:master Oct 6, 2020
@jonahwilliams
jonahwilliams deleted the cocoapods_validator branch October 6, 2020 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants