Repository navigation
[flutter_tools] remove globals and document flutter root initialization - #67275
Closed
jonahwilliams wants to merge 9 commits into
Closed
jonahwilliams wants to merge 9 commits into
jonahwilliams wants to merge 9 commits into
Conversation
flutter-dashboard
Bot
added
tool
jonahwilliams
commented
Oct 4, 2020
| } | ||
|
|
||
| // If run from a bare script within the repo. | ||
| if (script.contains('flutter/packages/')) { |
Contributor
Author
There was a problem hiding this comment.
I could not find a reasonable way to trigger this path so I removed it, it seems historical
jonahwilliams
commented
Oct 4, 2020
| Cache.flutterRoot = globals.fs.path.normalize(globals.fs.path.absolute(flutterRoot)); | ||
| if (topLevelResults.wasParsed('flutter-root')) { | ||
| Cache.flutterRoot = globals.fs.path.normalize( | ||
| globals.fs.path.absolute(topLevelResults['flutter-root'] as String)); |
Contributor
Author
There was a problem hiding this comment.
I think the flutter-root argument should be deprecated, because it massively complicates startup. The cache flutter root needs to be initialized before many of our interfaces are created/accessed for the first time, but arg parsing can only be done after a command has executed.
Since this is a fairly advanced use case, replacing it with the environment variable seems like a reasonable compromise.
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change. If you're changing visual properties, consider including before/after screenshots (and runnable code snippets to reproduce them).
Related Issues
Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR. There should be at least one issue listed here.
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behavior with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.