Repository navigation
Handle missing Android SDKs in getEmulators() - #67295
Merged
fluttergithubbot merged 1 commit intoOct 5, 2020
Merged
fluttergithubbot merged 1 commit into
fluttergithubbot merged 1 commit into
Conversation
Contributor
Author
|
@jonahwilliams the "Google testing" check seems to be still running - do you have any visibility of whether that's working/queued or broken? (I presume I shouldn't tag with waiting-for-tree-green until that passes, else the bot may still land it?). |
Contributor
|
If you tag with waiting for tree, it will wait for all status. Google testing can take a while sometimes, I can check if it is stuck |
Contributor
|
(I checked, still running) |
Contributor
Author
Ah, good to know - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue when calling the daemon's
getEmulators()method when there is no Android SDK located.Related Issues
Tests
I added the following tests:
nullin place of the Mock Android SDK that would fail with the same error in "The getter 'emulatorPath' was called on null" when calling daemon getEmulators() command #67293 without this fixChecklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.