Skip to content

Handle missing Android SDKs in getEmulators() - #67295

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
DanTup:handle-missing-android-sdk-for-emulators
Oct 5, 2020
Merged

fluttergithubbot merged 1 commit into
flutter:masterfrom
DanTup:handle-missing-android-sdk-for-emulators

Conversation

@DanTup

@DanTup DanTup commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

Description

Fixes an issue when calling the daemon's getEmulators() method when there is no Android SDK located.

Related Issues

Tests

I added the following tests:

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@DanTup

DanTup commented Oct 5, 2020

Copy link
Copy Markdown
Contributor Author

@jonahwilliams the "Google testing" check seems to be still running - do you have any visibility of whether that's working/queued or broken? (I presume I shouldn't tag with waiting-for-tree-green until that passes, else the bot may still land it?).

@jonahwilliams

Copy link
Copy Markdown
Contributor

If you tag with waiting for tree, it will wait for all status. Google testing can take a while sometimes, I can check if it is stuck

@jonahwilliams

Copy link
Copy Markdown
Contributor

(I checked, still running)

@DanTup

DanTup commented Oct 5, 2020

Copy link
Copy Markdown
Contributor Author

If you tag with waiting for tree, it will wait for all status.

Ah, good to know - thanks!

@fluttergithubbot
fluttergithubbot merged commit fdd1bf2 into flutter:master Oct 5, 2020
@DanTup
DanTup deleted the handle-missing-android-sdk-for-emulators branch October 5, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants