Repository navigation
[flutter_tools] remove globals from compile and devices - #67485
Merged
jonahwilliams merged 4 commits intoOct 8, 2020
Merged
Conversation
flutter-dashboard
Bot
added
the
tool
This comment has been minimized.
This comment has been minimized.
jonahwilliams
changed the title
jmagman
reviewed
Oct 7, 2020
| _logger.printStatus(_userMessages.flutterMultipleDevicesFound); | ||
| await Device.printDevices(devices, _logger); | ||
| final Device chosenDevice = await _chooseOneOfAvailableDevices(devices); | ||
| globals.deviceManager.specifiedDeviceId = chosenDevice.id; |
jmagman
reviewed
Oct 7, 2020
| } | ||
| } | ||
|
|
||
| class MockProcess extends Mock implements Process {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove global variables from compile.dart and devices.dart (except for dds which needs more changes).
#47161