Repository navigation
[flutter_tools] document flutter root initialization - #67884
Merged
jonahwilliams merged 4 commits intoOct 27, 2020
Merged
Conversation
flutter-dashboard
Bot
added
tool
jonahwilliams
marked this pull request as ready for review
October 27, 2020 17:27
jonahwilliams
commented
Oct 27, 2020
| } | ||
|
|
||
| // If run from a bare script within the repo. | ||
| if (script.contains('flutter/packages/')) { |
Contributor
Author
There was a problem hiding this comment.
Could not find any usage of these
zanderso
approved these changes
Oct 27, 2020
| @required FileSystem fileSystem, | ||
| @required UserMessages userMessages, | ||
| }) { | ||
| String process(String path) { |
Member
There was a problem hiding this comment.
Maybe normalize instead of process?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the flutter root initialization to a static method on the cache. This is a small step towards making this functionality non-static and instead injected like normal members - however, completely removing all of the static-ness at once was too large of a change.
Instead document and add unit tests and change existing code as little as possible.
#47161