Skip to content

Correctly handle centerSlice with resoultion-aware assets. - #68325

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
Cyp:fix-centerSlice
Oct 23, 2020
Merged

Correctly handle centerSlice with resoultion-aware assets.#68325
fluttergithubbot merged 1 commit into
flutter:masterfrom
Cyp:fix-centerSlice

Conversation

@Cyp

@Cyp Cyp commented Oct 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This fixes both the centerSlice Rect being misinterpreted and the image being rendered too big.

Related Issues

Fixes #20013.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • 448540 issues found. (ran in 97.9s; 6488 public members lack documentation)
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change.

@flutter-dashboard

flutter-dashboard Bot commented Oct 16, 2020

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard Bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 16, 2020
@google-cla google-cla Bot added the cla: yes label Oct 16, 2020
@Cyp

Cyp commented Oct 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Unsure what the failure in the flutter-build test is, since the Details link target doesn't seem at all related to this PR.

[edit] Whatever it was, the failure disappeared by itself. Maybe someone re-ran the test?

[edit2] Now the failure reappeared. Why is flutter-build randomly changing between passed and failed? I assume it's completely unrelated to this PR…

[edit3] It's not failing, now. Yay!

[edit4] Oh no, it's failing again!

[edit5] Phew, it's not failing anymore.

@goderbauer

goderbauer commented Oct 21, 2020

Copy link
Copy Markdown
Member

A failing flutter-build just means that the tests are currently failing on master - it's unrelated to your PR.

However, this PR is missing a test. Can you please add one? Thanks.

@Cyp
Correctly handle centerSlice with resoultion-aware assets.
277e5cb 
This fixes both the centerSlice Rect being misinterpreted and the image being rendered too big.

Fixes flutter#20013.
@Cyp
Cyp force-pushed the fix-centerSlice branch from 7636090 to 277e5cb Compare October 22, 2020 11:31
@Cyp

Cyp commented Oct 22, 2020

Copy link
Copy Markdown
Contributor Author

Added a test, now.

@HansMuller
HansMuller requested a review from dnfield October 22, 2020 23:35
dnfield
dnfield approved these changes Oct 23, 2020
View reviewed changes

@dnfield dnfield left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
fluttergithubbot merged commit 45e02da into flutter:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dnfield dnfield dnfield approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

centerSlice doesn't work properly with resolution-aware image assets

4 participants

@Cyp @goderbauer @dnfield @fluttergithubbot