Repository navigation
Turn off CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER in CocoaPod targets - #68817
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CocoaPods 1.10 does this as of CocoaPods/CocoaPods#9902 to avoid warnings and errors in Xcode 12. Duplicate the behavior in Flutter for users on older versions (minimum required is 1.6, 1.8 is recommended).
This warning plays poorly with pods that also opt into treating warnings as errors, which causes compilation failures, not just warnings:
https://github.com/CocoaPods/Specs/blob/master/Specs/b/c/f/GoogleDataTransportCCTSupport/3.2.0/GoogleDataTransportCCTSupport.podspec.json#L56
Related Issues
Fixes #68813
Tests
I'm not sure how to test this, but I reproduced the compilation failure locally, and confirmed it no longer produces errors or warnings related to quoted includes.
ios/Podfile, then to that addGoogleDataTransportCCTSupportcd ios && pod installios/Runner.xcworkspacein Xcode 12 and turn on "Quoted Include in Framework Header" build setting in the Pods target or run the "Update build settings" migrator thing.flutter build iosfailsApply this patch, no more failures.