Skip to content

[flutter_tools] allow default driver log to fail due to IO error - #69316

Merged
jonahwilliams merged 1 commit into
flutter:masterfrom
jonahwilliams:make_log_resillient
Oct 29, 2020
Merged

jonahwilliams merged 1 commit into
flutter:masterfrom
jonahwilliams:make_log_resillient

Conversation

@jonahwilliams

Copy link
Copy Markdown
Contributor

Description

Fixes #69314

@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard Bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Oct 29, 2020
@google-cla google-cla Bot added the cla: yes label Oct 29, 2020

@yjbanov yjbanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonahwilliams
jonahwilliams merged commit 246bf60 into flutter:master Oct 29, 2020
@jonahwilliams
jonahwilliams deleted the make_log_resillient branch October 29, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash in FlutterDriverExtension on integration_ui_ios_driver

2 participants