Repository navigation
Combine date and time picker demos - #6933
Merged
HansMuller merged 4 commits intoNov 21, 2016
Merged
Conversation
Hixie
reviewed
Nov 19, 2016
Hixie
reviewed
Nov 19, 2016
Contributor
There was a problem hiding this comment.
looks like you missed time_picker_demo.dart
Contributor
Author
There was a problem hiding this comment.
Yes I did, good catch!
Contributor
|
What do you think of merging this and the other text input demo as well? Also, what do you think of exposing the widgets you made here as actual widgets in the material layer? LGTM. |
HansMuller
force-pushed
the
combine_date_and_time_picker_demos
branch
from
November 21, 2016 19:36
621c524 to
92446bd
Compare
Contributor
Author
|
I think you're right about providing InputDropdown and/or DateTimePicker as canned material widgets. Before doing that I want to resolve a few more of the outstanding dropdown issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new demo also demonstrates how to create a form whose elements are all labeled and hinted like Input widgets.
Fixes #6604