Repository navigation
Improve docs for Input and Form and friends. - #7208
Merged
Merged
Conversation
Hixie
reviewed
Dec 9, 2016
Contributor
There was a problem hiding this comment.
Newline after the first sentence.
Rather than just directing people elsewhere in this style, we usually say something like "This widget is useful if baz. If you want foo, consider bar."
Hixie
reviewed
Dec 9, 2016
Hixie
reviewed
Dec 9, 2016
Hixie
reviewed
Dec 9, 2016
Hixie
reviewed
Dec 9, 2016
Hixie
reviewed
Dec 9, 2016
Hixie
reviewed
Dec 9, 2016
Contributor
There was a problem hiding this comment.
here and the cases below, s/val/value/
Hixie
reviewed
Dec 9, 2016
Contributor
There was a problem hiding this comment.
wrap this so it's longer, to make it obvious that there's more going on here than in the other example
Contributor
|
This is great. LGTM with the above changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7017