Repository navigation
Conversation
This will allow the following command to print machine readable output: ``` flutter drive --driver=test_driver/driver.dart --target=lib/main.dart --test-arguments='--reporter=json' ``` Things that are needed: 1. Actually use the test executable from package:test. Or wrap that executable somehow like how `flutter test` does it 2. Make `test-arguments` pass args to the test script rather than the Dart executable
flutter-dashboard
Bot
added
the
tool
| return _processUtils.stream(<String>[ | ||
| _dartSdkPath, | ||
| ...<String>[...arguments, testFile, '-rexpanded'], | ||
| // This is probably not the correct way of calling the executable from |
Contributor
There was a problem hiding this comment.
This won't work reliably because pub will sometimes thing that pub run needs to be repeated
Contributor
|
@jiahaog I'm going to close this one since it looks like we decided not to land it. Feel free to reopen it if it's still relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(This is a quick hack)
This will allow the following command to print machine readable output:
Things that are needed:
flutter testdoes ittest-argumentspass args to the test script rather than the Dart executableRelated Issues
#51135
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behavior with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.