Skip to content

[flutter_tools] daemon does not report platforms that are not enabled - #73736

Merged
jonahwilliams merged 1 commit into
flutter:masterfrom
jonahwilliams:capabilities_ide
Jan 12, 2021
Merged

jonahwilliams merged 1 commit into
flutter:masterfrom
jonahwilliams:capabilities_ide

Conversation

@jonahwilliams

Copy link
Copy Markdown
Contributor

Currently the IDEs use this daemon command to determine which devices to show in the launcher. If a project has a directory for android/ios but this feature is disabled, make sure this isn't returned as a supported platform.

Also added first test for supportedPlatforms.

@flutter-dashboard flutter-dashboard Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 11, 2021
@jonahwilliams
jonahwilliams requested a review from DanTup January 11, 2021 21:49
@google-cla google-cla Bot added the cla: yes label Jan 11, 2021

testWithoutContext('does not run any operations concurrently', () async {
// Crete a function thats slow, but throws if another instance of the
// Crete a function that's slow, but throws if another instance of the

@thecalamiity thecalamiity Jan 12, 2021 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Create* 😅

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhh, if you wanna send a PR for this I'd be happy to review :)

@DanTup DanTup left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants