Skip to content

Enable hot reload test for Windows desktop - #73862

Closed
stuartmorgan-g wants to merge 1 commit into
flutter:masterfrom
stuartmorgan-g:windows-desktop-device-lab-initial
Closed

stuartmorgan-g wants to merge 1 commit into
flutter:masterfrom
stuartmorgan-g:windows-desktop-device-lab-initial

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Contributor

Bring up the hot reload devicelab test for Windows desktop. This also serves as a test case for ensuring Windows desktop tests can be run successfully on devicelab, since this is the first Windows desktop devicelab test.

Part of #54295

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard Bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jan 13, 2021
@google-cla google-cla Bot added the cla: yes label Jan 13, 2021
@stuartmorgan-g
stuartmorgan-g marked this pull request as draft January 13, 2021 15:22
@stuartmorgan-g
stuartmorgan-g deleted the windows-desktop-device-lab-initial branch January 13, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant