Skip to content

Drop metrics_center - #74535

Merged
dnfield merged 3 commits into
flutter:masterfrom
dnfield:drop_mc
Jan 23, 2021
Merged

dnfield merged 3 commits into
flutter:masterfrom
dnfield:drop_mc

Conversation

@dnfield

@dnfield dnfield commented Jan 22, 2021

Copy link
Copy Markdown
Contributor

This package is published to pub. It should be in the flutter/packages repo.

Main motivator for this right now is that it depends on googleapis_auth, which transitively depends on other things that are making it difficult to roll NNBD deps.

This has no impact on the repo currently, since the package is vended from pub.

@dnfield
dnfield requested review from liyuqian and zanderso January 22, 2021 23:16
@flutter-dashboard flutter-dashboard Bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jan 22, 2021
@google-cla google-cla Bot added the cla: yes label Jan 22, 2021

@liyuqian liyuqian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield changed the title Drop mc Drop metrics_center Jan 22, 2021
@zanderso

Copy link
Copy Markdown
Member

It looks like this PR is doing several different things including an engine roll. Can this be split apart into separate changes?

@zanderso

Copy link
Copy Markdown
Member

Nevermind. I think github was showing me an old commit.

@dnfield

dnfield commented Jan 23, 2021

Copy link
Copy Markdown
Contributor Author

@zanderso - I think I'm missing something. I only see deleting dev/benchmarks/metrics_center.

@dnfield

dnfield commented Jan 23, 2021

Copy link
Copy Markdown
Contributor Author

Not waiting for google testing since this code is not imported into google.

@dnfield
dnfield merged commit 0d046b3 into flutter:master Jan 23, 2021
@dnfield
dnfield deleted the drop_mc branch January 23, 2021 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants