Skip to content

Migrate flutter_goldens to NNBD - #74853

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
Piinks:migrateGoldens
Jan 28, 2021
Merged

Migrate flutter_goldens to NNBD#74853
fluttergithubbot merged 1 commit into
flutter:masterfrom
Piinks:migrateGoldens

Conversation

@Piinks

@Piinks Piinks commented Jan 27, 2021

Copy link
Copy Markdown
Contributor

Migrates the flutter_goldens package to null safety

Part of #71506
Fixes #74850

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. a: null-safety Support for Dart's null safety feature labels Jan 27, 2021
@google-cla google-cla Bot added the cla: yes label Jan 27, 2021
@Piinks
Piinks requested review from dnfield and goderbauer January 27, 2021 23:38
dnfield
dnfield approved these changes Jan 27, 2021
View reviewed changes

@dnfield dnfield left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

goderbauer
goderbauer approved these changes Jan 28, 2021
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
fluttergithubbot merged commit f04616f into flutter:master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes
+1 more reviewer
@dnfield dnfield dnfield approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: null-safety Support for Dart's null safety feature c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate flutter_goldens to null safety

4 participants

@Piinks @goderbauer @dnfield @fluttergithubbot