Skip to content

Compress module_test_ios xcresult - #75736

Merged
jmagman merged 1 commit into
flutter:masterfrom
jmagman:zip-xcresult
Feb 10, 2021
Merged

jmagman merged 1 commit into
flutter:masterfrom
jmagman:zip-xcresult

Conversation

@jmagman

@jmagman jmagman commented Feb 9, 2021 •

Copy link
Copy Markdown
Member

@jmagman jmagman added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels Feb 9, 2021
@jmagman jmagman self-assigned this Feb 9, 2021
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla Bot added the cla: yes label Feb 9, 2021
@jmagman
jmagman requested a review from jonahwilliams February 9, 2021 23:58

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
jmagman merged commit 4329bea into flutter:master Feb 10, 2021
@jmagman
jmagman deleted the zip-xcresult branch February 10, 2021 00:10
@jmagman jmagman added the a: tests "flutter test", flutter_test, or one of our tests label Aug 20, 2021
@jmagman jmagman mentioned this pull request Feb 1, 2024
7 of 8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compress module_test_ios xcresult in LUCI logs

2 participants