Repository navigation
Update gradle example to support x86 in debug mode. - #7606
Merged
Merged
Conversation
Changed the Flutter Gradle plugin a bit to better fit in with the Android build. Fixes flutter#6136 Fixes flutter#6864 Fixes flutter#7539
Member
|
LGTM |
Hixie
reviewed
Jan 25, 2017
|
|
||
| gradlew = locateProjectGradlew(); | ||
| if (gradlew == null) | ||
| if (gradlew == null) { |
Hixie
reviewed
Jan 25, 2017
| status.stop(); | ||
|
|
||
| if (exitcode != 0) | ||
| if (exitcode != 0) { |
Hixie
reviewed
Jan 25, 2017
| ); | ||
| status.stop(); | ||
|
|
||
| if (exitcode != 0) { |
Hixie
reviewed
Jan 25, 2017
| }) async { | ||
| if (platform != TargetPlatform.android_arm && buildMode != BuildMode.debug) { | ||
| throwToolExit( | ||
| 'Profile and release builds are only supported on ARM targets.'); |
Contributor
There was a problem hiding this comment.
nit: if you put a newline after the (, put a newline before the ).
mit-mit
reviewed
Jan 31, 2017
| compileSdkVersion 22 | ||
| buildToolsVersion '22.0.1' | ||
| compileSdkVersion 25 | ||
| buildToolsVersion '24.0.2' |
Member
There was a problem hiding this comment.
For a recent default installation of Android Studio, I see buildToolsVersion "25.0.2". Any reason to stick with 24 here?
Contributor
Author
There was a problem hiding this comment.
flutter build currently updates this to match the version of the SDK you're building with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the Flutter Gradle plugin a bit to better fit in with the Android build.
x86 shared libraries are added to debug builds, so they can now run on the emulator. Profile and release builds still only support ARM.
Invoking 'gradlew build' directly will now build all variants, like a normal Android build.
Fixes #6136
Fixes #6864
Fixes #7539