Repository navigation
Conversation
GaryQian
added
tool
17 of 18 tasks
Contributor
Author
|
Turns out that gradle will actually produce a very easy to parse error enumerating the missing imports that this PR computes. This means that this validator feature is not very necessary right now, though the benefit of this is that it is unified with the rest of the validator rather than depending on the gradle error output. |
Contributor
Author
|
We can reconsider adding this in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off of #75739 due to robustness concerns.
Implements parsing of the
android/settings.gradleand checks for the correct entries underincludes.