Skip to content

Add mac_ios luci tests. - #76358

Merged
godofredoc merged 1 commit into
flutter:masterfrom
godofredoc:add_mac_ios_tasks
Feb 22, 2021
Merged

Add mac_ios luci tests.#76358
godofredoc merged 1 commit into
flutter:masterfrom
godofredoc:add_mac_ios_tasks

Conversation

@godofredoc

@godofredoc godofredoc commented Feb 19, 2021

Copy link
Copy Markdown
Contributor

Mac/iOS luci tasks are ready to replace Cocoon Agent ones. This PR starts running all the luci tasks using the production pool test beds.

Bug: #73392

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Add mac_ios luci tests.
5862c4e 
Mac/iOS luci tasks are ready to replace Cocoon Agent ones. This PR start
running all the luci tasks using luci production pool test beds.

Bug: #73392
@flutter-dashboard flutter-dashboard Bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 19, 2021
@google-cla google-cla Bot added the cla: yes label Feb 19, 2021
christopherfujino
christopherfujino approved these changes Feb 19, 2021
View reviewed changes

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

keyonghan
keyonghan approved these changes Feb 19, 2021
View reviewed changes

@keyonghan keyonghan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc
godofredoc merged commit 253db51 into flutter:master Feb 22, 2021
@godofredoc
godofredoc deleted the add_mac_ios_tasks branch February 22, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@christopherfujino christopherfujino christopherfujino approved these changes
@keyonghan keyonghan keyonghan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @christopherfujino @keyonghan