Skip to content

Use ScrollView in examples a manual_tests - #7645

Merged
abarth merged 1 commit into
flutter:masterfrom
abarth:deploy_scroll_view
Jan 26, 2017
Merged

abarth merged 1 commit into
flutter:masterfrom
abarth:deploy_scroll_view

Conversation

@abarth

@abarth abarth commented Jan 25, 2017 •

Copy link
Copy Markdown
Contributor

This patch deploys ScrollView in a number of demos and manual tests.

@abarth

abarth commented Jan 25, 2017

Copy link
Copy Markdown
Contributor Author

@Hixie

@abarth
abarth force-pushed the deploy_scroll_view branch from 73654b6 to 4774c7f Compare January 26, 2017 00:52
@abarth abarth changed the title Add a sliver-based ScrollView Use ScrollView in examples a manual_tests Jan 26, 2017
@Hixie

Hixie commented Jan 26, 2017

Copy link
Copy Markdown
Contributor

LGTM.

Summary of our discussion around this:

  • we won't include the shrine demo yet
  • there are three bugs to look into:
    • why does it go past the max scroll offset?
    • can we fix the numeric issue with the android simulation whereby it's not idempotent (if you create it with its current velocity, you get a different velocity)
    • can we figure out some magic way to avoid the missed frame when recreating the ballistic simulation?

This patch deploys ScrollView in a number of demos and manual tests.
@abarth
abarth force-pushed the deploy_scroll_view branch from 4774c7f to 6af6a96 Compare January 26, 2017 05:13
@abarth
abarth merged commit a4eca31 into flutter:master Jan 26, 2017
@abarth
abarth deleted the deploy_scroll_view branch January 26, 2017 05:59
@Hixie

Hixie commented Jan 27, 2017

Copy link
Copy Markdown
Contributor

This patch substantially improved the performance of the microbenchmarks.stock_animation_subsequent_frame and microbenchmarks.stock_animation_close_first_frame benchmarks.

@Hixie

Hixie commented Jan 27, 2017

Copy link
Copy Markdown
Contributor

It also increased code size for complex_layout aot_snapshot_size_instructions, but I expect that to reduce when we delete the old code which I presume is still somehow getting linked in here.

onPressed: _handleShowAbout,
child: new Text('About'))
])
child: new ScrollView(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change regressed the benchmark I just made from 3621.0 to 4519.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants