Repository navigation
Use ScrollView in examples a manual_tests - #7645
Merged
Merged
Conversation
Contributor
Author
abarth
force-pushed
the
deploy_scroll_view
branch
from
January 26, 2017 00:52
73654b6 to
4774c7f
Compare
Contributor
|
LGTM. Summary of our discussion around this:
|
This patch deploys ScrollView in a number of demos and manual tests.
abarth
force-pushed
the
deploy_scroll_view
branch
from
January 26, 2017 05:13
4774c7f to
6af6a96
Compare
Contributor
|
This patch substantially improved the performance of the microbenchmarks.stock_animation_subsequent_frame and microbenchmarks.stock_animation_close_first_frame benchmarks. |
Contributor
|
It also increased code size for complex_layout aot_snapshot_size_instructions, but I expect that to reduce when we delete the old code which I presume is still somehow getting linked in here. |
Hixie
reviewed
Feb 10, 2017
| onPressed: _handleShowAbout, | ||
| child: new Text('About')) | ||
| ]) | ||
| child: new ScrollView( |
Contributor
There was a problem hiding this comment.
This change regressed the benchmark I just made from 3621.0 to 4519.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch deploys ScrollView in a number of demos and manual tests.