Repository navigation
New scrollbars for the scrollable refactor - #7646
Merged
Merged
Conversation
abarth
reviewed
Jan 26, 2017
abarth
reviewed
Jan 26, 2017
Contributor
There was a problem hiding this comment.
I wonder if we should try to collapse out these repaint boundaries when the scroll bars are invisible.
Contributor
There was a problem hiding this comment.
Maybe add a TODO about that?
Contributor
Author
There was a problem hiding this comment.
is there some way we could make CustomPaint take a flag that decides whether to do it or not?
abarth
reviewed
Jan 26, 2017
Contributor
There was a problem hiding this comment.
For private names like these, I've just been putting them as file-level private constants.
Contributor
Author
There was a problem hiding this comment.
I left them here so they're closer to the code using them. Doesn't seem to matter either way.
abarth
reviewed
Jan 26, 2017
Contributor
There was a problem hiding this comment.
Please file a bug about smoothing this path.
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.