Repository navigation
Speed up hot reload in the framework. - #7647
Merged
Merged
Conversation
abarth
reviewed
Jan 26, 2017
Contributor
There was a problem hiding this comment.
You've got more ( and ) than you need here.
Contributor
|
|
Contributor
|
thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @abarth for review
cc @johnmccutchan after this, a profile of hot reload doesn't really have any framework hotspots, the framework side is really just the time it takes to walk the whole tree marking it dirty, build the whole tree, and lay out the whole tree. There's other things on the profile, though. For example top thing on the profile is
fatstat, and second thing is "[Stub] Subtype1TestCache" which I don't know what to do with. The timeline shows that we spend time roughly in the ratios 40:50:15:10 for walking the tree marking it dirty, rebuilding it, laying it out, and painting it. About half the first part is walking the element tree and the other half is walking the render tree.