Repository navigation
Conversation
jmagman
added
c: contributor-productivity
flutter-dashboard
Bot
added
the
tool
7031800 to
adfb576
Compare
adfb576 to
5d72fd3
Compare
| } | ||
| final Map<Environment, Set<String>> _existingArchsByEnvironment = <Environment, Set<String>>{}; | ||
|
|
||
| String _lipoOutput(Environment environment) { |
There was a problem hiding this comment.
Why is the cache/lack of const necessary?
There was a problem hiding this comment.
So lipo -info isn't called twice, once to see if it can be skipped, then a second time when build is called.
However that call is extremely fast (on my machine 0.00s user 0.00s system 73% cpu 0.012 total) so I can be convinced the extra complexity/lack of const isn't worth it.
There was a problem hiding this comment.
maybe it is worth it, but then you'd need to be sure that any targets that declare this as a dependency use the same instance of this object - otherwise you will repeat the work anyway
There was a problem hiding this comment.
generally I would say ensure correctness first and then hit performance later. Since the rest of the target instances are used in a const manner I would say its safer to keep this class more like them
2 participants
Implement
ThinIosApplicationFrameworks.canSkip(). If Flutter.framework contains exactly the requested architectures (the x86_64 simulator framework orxcarchive, for example), then don'tlipo -extractanything.Follow up to #76665.