Skip to content

Move flaky flag from the remainin mac/ios tests. - #76960

Merged
godofredoc merged 1 commit into
flutter:masterfrom
godofredoc:third_batch
Mar 1, 2021
Merged

Move flaky flag from the remainin mac/ios tests.#76960
godofredoc merged 1 commit into
flutter:masterfrom
godofredoc:third_batch

Conversation

@godofredoc

@godofredoc godofredoc commented Mar 1, 2021

Copy link
Copy Markdown
Contributor

Bug: #73392

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 1, 2021
@google-cla google-cla Bot added the cla: yes label Mar 1, 2021
keyonghan
keyonghan approved these changes Mar 1, 2021
View reviewed changes

@keyonghan keyonghan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jmagman
jmagman approved these changes Mar 1, 2021
View reviewed changes

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@godofredoc
godofredoc merged commit ceef328 into flutter:master Mar 1, 2021
@godofredoc
godofredoc deleted the third_batch branch March 1, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes
@yusufm yusufm Awaiting requested review from yusufm
+1 more reviewer
@keyonghan keyonghan keyonghan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @jmagman @keyonghan