Skip to content

Re-land "Toggable Refactor (#76745)" - #77263

Merged
fluttergithubbot merged 2 commits into
flutter:masterfrom
goderbauer:reapplytoggle
Mar 4, 2021
Merged

fluttergithubbot merged 2 commits into
flutter:masterfrom
goderbauer:reapplytoggle

Conversation

@goderbauer

@goderbauer goderbauer commented Mar 4, 2021 •

Copy link
Copy Markdown
Member

This reverts 328a262 and re-applies #76745 with fixes to the android_semantics_integration_test. The changes over #76745 are limited to the 'dev/integration_tests/android_semantics_testing/test_driver/main_test.dart` file (see last commit in this PR).

Fixes #76411.

@flutter-dashboard flutter-dashboard Bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 4, 2021
@google-cla google-cla Bot added the cla: yes label Mar 4, 2021
@goderbauer
goderbauer requested a review from HansMuller March 4, 2021 17:29

@HansMuller HansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when Toggleable widget disappears while pointer is down

3 participants