Skip to content

Add debug_second_compile_millis benchmark metric - #77420

Merged
jmagman merged 1 commit into
flutter:masterfrom
jmagman:measure-second-compile
Mar 5, 2021
Merged

Add debug_second_compile_millis benchmark metric#77420
jmagman merged 1 commit into
flutter:masterfrom
jmagman:measure-second-compile

Conversation

@jmagman

@jmagman jmagman commented Mar 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Start measuring how long the second compilation of an app takes, without cleaning, with the same parameters.
This will allow us to track how effectively build steps are being cached between runs and catch regressions.

$ dart bin/run.dart -t hello_world_ios__compile
...
    "debug_full_compile_millis": 18052,
    "debug_second_compile_millis": 11001

$ dart bin/run.dart -t hello_world_android__compile
    "debug_full_compile_millis": 15143,
    "debug_second_compile_millis": 4530

#67580 (comment)

@jmagman jmagman added platform-android Android applications specifically platform-ios iOS applications specifically team: benchmark Performance issues found by inspecting benchmarks labels Mar 5, 2021
@jmagman jmagman self-assigned this Mar 5, 2021
@flutter-dashboard flutter-dashboard Bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 5, 2021
@flutter-dashboard

flutter-dashboard Bot commented Mar 5, 2021

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla Bot added the cla: yes label Mar 5, 2021
@jmagman jmagman mentioned this pull request Mar 5, 2021
Closed
@jmagman
jmagman requested a review from xster March 5, 2021 22:30
@jmagman jmagman mentioned this pull request Mar 5, 2021
Open
@jmagman
jmagman requested a review from jonahwilliams March 5, 2021 22:35
jonahwilliams
jonahwilliams approved these changes Mar 5, 2021
View reviewed changes

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmagman
jmagman merged commit e9e8ca7 into flutter:master Mar 5, 2021
@jmagman
jmagman deleted the measure-second-compile branch March 5, 2021 23:33
@jmagman jmagman mentioned this pull request Mar 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xster xster xster approved these changes
+1 more reviewer
@jonahwilliams jonahwilliams jonahwilliams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. platform-android Android applications specifically platform-ios iOS applications specifically team: benchmark Performance issues found by inspecting benchmarks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @xster @jonahwilliams