Skip to content

Add CupertinoScrollbar api docs - #78284

Merged
fluttergithubbot merged 18 commits into
flutter:masterfrom
Abhishek01039:CupertinoScrollbar_sample
May 18, 2021
Merged

Add CupertinoScrollbar api docs#78284
fluttergithubbot merged 18 commits into
flutter:masterfrom
Abhishek01039:CupertinoScrollbar_sample

Conversation

@Abhishek01039

@Abhishek01039 Abhishek01039 commented Mar 16, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add the sample of the CupertinoScrollbar widget

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added p: cupertino_ui cupertino_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Mar 16, 2021
@flutter-dashboard

flutter-dashboard Bot commented Mar 16, 2021

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla Bot added the cla: yes label Mar 16, 2021
@Abhishek01039

Abhishek01039 commented Mar 16, 2021

Copy link
Copy Markdown
Contributor Author

Hello @Piinks
Can you please review this PR?
Thanks

@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation labels Mar 16, 2021
Piinks
Piinks requested changes Mar 16, 2021
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like the exact same samples from Scrollbar, can we either make them unique? Or define a template so we can re-use without duplicating the code?

Comment thread packages/flutter/lib/src/cupertino/scrollbar.dart Outdated
Piinks
Piinks reviewed Mar 16, 2021
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CupertinoScrollbar has some unique behavior like when the size changes on drag, maybe it would be beneficial to showcase that. :)

@Piinks Piinks mentioned this pull request Apr 5, 2021
Closed
4 of 5 tasks
@Abhishek01039
Abhishek01039 requested a review from Piinks April 12, 2021 16:05
Piinks
Piinks reviewed Apr 15, 2021
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Abhishek01039, this does not mention the unique features of the CupertinoScrollbar, like thicknessWhileDragging?

@Abhishek01039

Abhishek01039 commented Apr 15, 2021

Copy link
Copy Markdown
Contributor Author

Ok, let me add this please

@Abhishek01039
Abhishek01039 requested a review from Piinks April 15, 2021 17:20
Piinks
Piinks reviewed Apr 16, 2021
View reviewed changes
Comment thread packages/flutter/lib/src/cupertino/scrollbar.dart
Comment thread packages/flutter/lib/src/cupertino/scrollbar.dart Outdated
@Abhishek01039
Abhishek01039 requested a review from Piinks April 26, 2021 12:16
@Abhishek01039

Abhishek01039 commented May 3, 2021

Copy link
Copy Markdown
Contributor Author

Hello @Piinks
can you please review this PR?
Thanks

Piinks
Piinks reviewed May 10, 2021
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Abhishek01039 please check the failing analyzer check

Comment thread packages/flutter/lib/src/cupertino/scrollbar.dart Outdated
Comment thread packages/flutter/lib/src/cupertino/scrollbar.dart Outdated
Comment thread packages/flutter/lib/src/cupertino/scrollbar.dart Outdated
Comment thread packages/flutter/lib/src/cupertino/scrollbar.dart Outdated
Comment thread packages/flutter/lib/src/cupertino/scrollbar.dart Outdated
Comment thread packages/flutter/lib/src/cupertino/scrollbar.dart Outdated
Comment thread packages/flutter/lib/src/cupertino/scrollbar.dart Outdated
Comment thread packages/flutter/lib/src/cupertino/scrollbar.dart Outdated
@Abhishek01039
Abhishek01039 requested a review from Piinks May 13, 2021 13:29
Piinks
Piinks approved these changes May 17, 2021
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@fluttergithubbot

fluttergithubbot commented May 17, 2021

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • This commit has empty status or empty checks. Please check the Google CLA status is present and Flutter Dashboard application has multiple checks.

@Abhishek01039
Abhishek01039 requested a review from Piinks May 18, 2021 04:51
Piinks
Piinks approved these changes May 18, 2021
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating!

@fluttergithubbot
fluttergithubbot merged commit b353f15 into flutter:master May 18, 2021
@Abhishek01039

Abhishek01039 commented May 18, 2021

Copy link
Copy Markdown
Contributor Author

Thanks @Piinks

@Abhishek01039
Abhishek01039 deleted the CupertinoScrollbar_sample branch May 21, 2021 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Abhishek01039 @fluttergithubbot @Piinks