Skip to content

Revert "Reland "fixes TextInputFormatter gets wrong old value of a se… - #78439

Closed
lukepighetti wants to merge 2 commits into
flutter:masterfrom
lukepighetti:lukepighetti/dev/issue-77855
Closed

Revert "Reland "fixes TextInputFormatter gets wrong old value of a se…#78439
lukepighetti wants to merge 2 commits into
flutter:masterfrom
lukepighetti:lukepighetti/dev/issue-77855

Conversation

@lukepighetti

@lukepighetti lukepighetti commented Mar 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Revert "Reland "fixes TextInputFormatter gets wrong old value of a selection" (#76653)"

Related issue (#77855)

This reverts commit b0d4d44.

Description

After b0d4d44 an issue appeared on macOS where if the user smashed their keys it would create an infinite loop where the text selection and contents would jitter.

At the same time, a bug manifested when used in concert with flutter_masked_text where any masked input would cause the cursor to not operate as expected, staying put when the mask inserted a character (?). This manifested itself on multiple platforms.

I am requesting this commit be merged into dev as a hotfix until a suitable replacement for b0d4d44 can be found.

I am also requesting clarification on my responsibilities for tests in this particular PR.

MCVE

#77855 (comment)

Resolves

#77855

The issue

77855-bad

The fix

77855-good

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
flutter-dashboard Bot changed the base branch from dev to master March 17, 2021 17:45
@flutter-dashboard

flutter-dashboard Bot commented Mar 17, 2021

Copy link
Copy Markdown

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to dev. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard Bot added engine flutter/engine related. See also e: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Mar 17, 2021
@google-cla google-cla Bot added the cla: yes label Mar 17, 2021
@lukepighetti
lukepighetti changed the base branch from master to dev March 17, 2021 17:49
@lukepighetti lukepighetti mentioned this pull request Mar 17, 2021
Closed
@justinmc
justinmc requested a review from chunhtai March 17, 2021 18:16
@chunhtai

chunhtai commented Mar 17, 2021

Copy link
Copy Markdown
Contributor

We can't merge this to the dev directly, we will have to merge this to the master and ask for cherry picking. This will be a hard revert because some other commit has landed on top of that.

@lukepighetti
lukepighetti changed the base branch from dev to master March 17, 2021 18:23
@lukepighetti

lukepighetti commented Mar 17, 2021

Copy link
Copy Markdown
Contributor Author

We can't merge this to the dev directly, we will have to merge this to the master and ask for cherry picking. This will be a hard revert because some other commit has landed on top of that.

Switched base to master. Any guidance on the viability of this PR and anything I can do to improve it?

@chunhtai

chunhtai commented Mar 17, 2021

Copy link
Copy Markdown
Contributor

Let me see if I can come up with a fix without reverting the commit.

@lukepighetti

lukepighetti commented Mar 17, 2021

Copy link
Copy Markdown
Contributor Author

Closed due to #77855 (comment), thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai Awaiting requested review from chunhtai

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukepighetti @chunhtai @renyou