Skip to content

Remove ignores that are not ignoring anything - #78669

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
goderbauer:missedIgnores
Mar 24, 2021
Merged

Remove ignores that are not ignoring anything#78669
fluttergithubbot merged 1 commit into
flutter:masterfrom
goderbauer:missedIgnores

Conversation

@goderbauer

@goderbauer goderbauer commented Mar 20, 2021

Copy link
Copy Markdown
Member

@shihaohong To unblock dart-lang/sdk#35234 I am removing the unnecessary // ignore:s from the generated i18n code. I've filed an issue to update the generator.

@flutter-dashboard flutter-dashboard Bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 20, 2021
@flutter-dashboard

flutter-dashboard Bot commented Mar 20, 2021

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@goderbauer
goderbauer requested a review from shihaohong March 20, 2021 00:17
@google-cla google-cla Bot added the cla: yes label Mar 20, 2021
@goderbauer goderbauer mentioned this pull request Mar 20, 2021
Closed
shihaohong
shihaohong approved these changes Mar 22, 2021
View reviewed changes

@shihaohong shihaohong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The other checks are failing with some unrelated, strange messages

@fluttergithubbot

fluttergithubbot commented Mar 22, 2021

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-misc-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot

fluttergithubbot commented Mar 22, 2021

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite framework_tests-widgets-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-libraries-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite tool_tests-commands-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
fluttergithubbot merged commit cec6491 into flutter:master Mar 24, 2021
@shihaohong shihaohong mentioned this pull request Mar 24, 2021
Closed
@goderbauer
goderbauer deleted the missedIgnores branch March 3, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@shihaohong shihaohong shihaohong approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goderbauer @fluttergithubbot @shihaohong