Repository navigation
Add split Linux docs jobs to prod builder json - #78888
Merged
Merged
Conversation
jmagman
added
the
c: contributor-productivity
jmagman
commented
Mar 23, 2021
jmagman
changed the title
godofredoc
reviewed
Mar 23, 2021
| "task_name": "linux_docs_test", | ||
| "flaky": true | ||
| }, | ||
| { |
Contributor
There was a problem hiding this comment.
Should Linux docs_publish run only in release branches? adding it here will run it for master.
Member
Author
There was a problem hiding this comment.
I think it's supposed to run on master, just not the release candidate branches:
https://github.com/flutter/infra/blob/e83d25832f6b56a7651365076eb842f57328343a/config/packaging_config.star#L149-L152
# Docs builds are only done on master and stable channels
if branch in ("master", "stable"):
common.linux_prod_builder(
name = "Linux%s docs_publish|docs" % ("" if branch == "master" else " " + branch),
I'll wait until @christopherfujino comes back from vacation, he can validate that's what he intended.
Contributor
There was a problem hiding this comment.
this change is correct, provided we follow-up to mark un-flaky.
confusingly, docs are published only on master (https://master-api.flutter.dev) and stable channels (https://api.flutter.dev).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Linux docsprod builder was split intoLinux docs_testandLinux docs_publishin https://github.com/flutter/infra/pull/375. Add them to the framework builders json file.Linux docswas showing up as not running:Note the try job is still called
Linux docs.Fixes #78887