Skip to content

[versions] roll many versions - #79088

Merged
jonahwilliams merged 3 commits into
flutter:masterfrom
jonahwilliams:roll-version-finally-unstuck
Mar 25, 2021
Merged

[versions] roll many versions#79088
jonahwilliams merged 3 commits into
flutter:masterfrom
jonahwilliams:roll-version-finally-unstuck

Conversation

@jonahwilliams

@jonahwilliams jonahwilliams commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

Most of our versions are unstuck now, still not test

@jonahwilliams
jonahwilliams requested a review from Piinks as a code owner March 25, 2021 21:00
@flutter-dashboard flutter-dashboard Bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 25, 2021
@flutter-dashboard

flutter-dashboard Bot commented Mar 25, 2021

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla Bot added the cla: yes label Mar 25, 2021
jmagman
jmagman approved these changes Mar 25, 2021
View reviewed changes

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman

jmagman commented Mar 25, 2021

Copy link
Copy Markdown
Member 
00:03 +4 ~1 -1: test/prepare_package_test.dart: Throws on missing executable [E]                                                                                                                       
  Expected: contains 'Invalid argument(s): Failed to resolve this_executable_better_not_exist_2857632534321 to an executable.'
    Actual: 'Running "this_executable_better_not_exist_2857632534321" in /opt/s/w/ir/k/flutter/dev/bots failed with:\n'
              'ProcessException: Failed to find "this_executable_better_not_exist_2857632534321" in the search path.\n'
              '  Command: this_executable_better_not_exist_2857632534321 '
  
  package:test_api                     expect
  test/prepare_package_test.dart 30:7  main.<fn>

@jonahwilliams

jonahwilliams commented Mar 25, 2021

Copy link
Copy Markdown
Contributor Author

Fixed!

@jonahwilliams jonahwilliams mentioned this pull request Mar 25, 2021
Closed
@jonahwilliams

jonahwilliams commented Mar 25, 2021

Copy link
Copy Markdown
Contributor Author

version rolls will not affect g3, landing

@jonahwilliams
jonahwilliams merged commit dfc134d into flutter:master Mar 25, 2021
@jonahwilliams
jonahwilliams deleted the roll-version-finally-unstuck branch March 25, 2021 22:43
@pinkasey

pinkasey commented Apr 19, 2021

Copy link
Copy Markdown

Hope it's OK to ask here -
when will this reach stable channel?

I want to migrate to null-safety, and the flutter_driver in channel stable is not compatible.
I believe that this change will allow me to proceed (right now I'm stuck because of args: 1.6.0)

@jonahwilliams

jonahwilliams commented Apr 19, 2021

Copy link
Copy Markdown
Contributor Author

I do not know exactly when the next stable release will be ready, but we generally do one release a quarter and the next one is soon-ish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes
@Piinks Piinks Awaiting requested review from Piinks

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonahwilliams @jmagman @pinkasey