Skip to content

Migrate code_signing to null safety - #79342

Merged
jmagman merged 1 commit into
flutter:masterfrom
jmagman:null-code-sign
Mar 30, 2021
Merged

Migrate code_signing to null safety#79342
jmagman merged 1 commit into
flutter:masterfrom
jmagman:null-code-sign

Conversation

@jmagman

@jmagman jmagman commented Mar 30, 2021

Copy link
Copy Markdown
Member

Remove globals and testUsingContext.

This let me remove MockIosProject from that test, move it from mocks.dart to the only remaining spot it was used in simulators_test, and convert it to FakeIosProject.

Part of #71511

@jmagman jmagman added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. a: null-safety Support for Dart's null safety feature labels Mar 30, 2021
@jmagman jmagman self-assigned this Mar 30, 2021
@google-cla google-cla Bot added the cla: yes label Mar 30, 2021
jmagman
jmagman commented Mar 30, 2021
View reviewed changes
Comment thread packages/flutter_tools/lib/src/ios/code_signing.dart
?.group(1);
})
.where(_isNotEmpty)
.whereType<String>()

@jmagman jmagman Mar 30, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat.

@jmagman
jmagman requested a review from jonahwilliams March 30, 2021 05:00
jonahwilliams
jonahwilliams approved these changes Mar 30, 2021
View reviewed changes

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmagman
jmagman merged commit 5d87b3e into flutter:master Mar 30, 2021
@jmagman
jmagman deleted the null-code-sign branch March 30, 2021 15:19
@jmagman jmagman mentioned this pull request Mar 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jonahwilliams jonahwilliams jonahwilliams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: null-safety Support for Dart's null safety feature c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @jonahwilliams