Skip to content

Rolls isKeyboardKey engine change with fix - #79407

Merged
cbracken merged 6 commits into
flutter:masterfrom
abrush21:is-keyboard-roll
Mar 31, 2021
Merged

Rolls isKeyboardKey engine change with fix#79407
cbracken merged 6 commits into
flutter:masterfrom
abrush21:is-keyboard-roll

Conversation

@abrush21

@abrush21 abrush21 commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

This change rolls engine change #25167 with fixes for breaking tests.

List which issues are fixed by this PR. You must list at least one issue.
fxb/71376

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. labels Mar 30, 2021
@google-cla google-cla Bot added the cla: yes label Mar 30, 2021
@flar

flar commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

Looks like some analyzer errors in there:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8851297438031365424/+/steps/prepare_environment/0/steps/Analyze/0/steps/analyze/0/stdout

And some semantic tests still failing:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8851297438031365408/+/steps/run_build_aar_module_test/0/stdout

@abrush21
[fuchsia] Fix roll of engine PR flutter#25167
9864381 
This changes fixes tests failing due to new isKeyboardKey semantics
flag.
@flar

flar commented Mar 31, 2021

Copy link
Copy Markdown
Contributor

It looks like one more doc error:

dartdoc:stderr:   error: unresolved doc reference [SemanticsConfiguration.isKyeboardKey], from rendering.RenderSemanticsAnnotations.keyboardKey: (file:///b/s/w/ir/k/flutter%20sdk/packages/flutter/lib/src/rendering/proxy_box.dart:3927:13)

@zanderso
zanderso marked this pull request as ready for review March 31, 2021 15:20
@cbracken
cbracken merged commit beb62a6 into flutter:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abrush21 @flar @cbracken @zanderso