Repository navigation
[flutter_tools] remove globals from Device and separate FlutterDeviceManager - #79454
Merged
Merged
Conversation
flutter-dashboard
Bot
added
the
tool
jonahwilliams
commented
Mar 31, 2021
| import 'windows/windows_workflow.dart'; | ||
|
|
||
|
|
||
| class FlutterDeviceManager extends DeviceManager { |
Contributor
Author
There was a problem hiding this comment.
The only purpose of this class is to construct dependencies for the injection, it can be one of the last things we migrate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make this easier to migrate to null safety, remove the globals dependencies and then move the instantiation of all of the device discovery classes into a new library.
#71511