Skip to content

Revert "Support block delete with word and line modifiers (#77172)" - #79674

Merged
gspencergoog merged 1 commit into
flutter:masterfrom
gspencergoog:revert_pr
Apr 2, 2021
Merged

gspencergoog merged 1 commit into
flutter:masterfrom
gspencergoog:revert_pr

Conversation

@gspencergoog

Copy link
Copy Markdown
Contributor

This reverts commit 75453e6 because it breaks flutter/test/rendering/editable_test.dart

TBR= @justinmc @canastro

)"

This reverts commit 75453e6 because it breaks flutter/test/rendering/editable_test.dart
@flutter-dashboard flutter-dashboard Bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 2, 2021
@google-cla google-cla Bot added the cla: yes label Apr 2, 2021
@gspencergoog
gspencergoog merged commit 8859f7a into flutter:master Apr 2, 2021
@gspencergoog
gspencergoog deleted the revert_pr branch April 2, 2021 22:08
@justinmc

justinmc commented Apr 2, 2021

Copy link
Copy Markdown
Contributor

@canastro Would you be able to fix that failure and open a new PR to unrevert this? I'm not sure why this didn't fail pre-merge. This was the failure, on Mac:

https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20framework_tests_libraries/b8851027005183932560/overview

00:42 +1356 ~13 -1: /opt/s/w/ir/k/flutter/packages/flutter/test/rendering/editable_test.dart: arrow keys and delete handle surrogate pairs correctly case 2 [E]                                        
  Expected: ''
    Actual: '👍'
     Which: is different. Both strings start the same, but the actual value also has the following trailing characters: 👍
  
  package:test_api                                   expect
  package:flutter_test/src/widget_tester.dart 441:3  expect
  test/rendering/editable_test.dart 1116:5           main.<fn>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants