Skip to content

[flutter_tools] migrate cache to null safety - #79864

Merged
fluttergithubbot merged 2 commits into
flutter:masterfrom
jonahwilliams:cache_null_safe
Apr 6, 2021
Merged

fluttergithubbot merged 2 commits into
flutter:masterfrom
jonahwilliams:cache_null_safe

Conversation

@jonahwilliams

@jonahwilliams jonahwilliams commented Apr 6, 2021 •

Copy link
Copy Markdown
Contributor

Part of #71511

Migrates the cache to null safety. This is mostly the same API, with the caveat that flutterRoot now defaults to null. There were too many tests that failed when I made it late, though we should consider revisiting that in the future to catch cases where we're not running the setup we think we are

@flutter-dashboard flutter-dashboard Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 6, 2021
@google-cla google-cla Bot added the cla: yes label Apr 6, 2021
@jonahwilliams
jonahwilliams marked this pull request as ready for review April 6, 2021 13:48
@jonahwilliams
jonahwilliams requested a review from jmagman April 6, 2021 14:47

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants