Repository navigation
Find VS Code installations with Spotlight query on macOS - #80477
Merged
Merged
Conversation
jmagman
added
tool
This was referenced Apr 15, 2021
| return _findInstalled(<_VsCodeInstallLocation>[ | ||
| _VsCodeInstallLocation( | ||
| // Query Spotlight for unexpected installation locations. | ||
| final ProcessResult vsCodeSpotlightQueryResult = processManager.runSync(<String>[ |
Contributor
There was a problem hiding this comment.
do we catch process exceptions in a higher scope? operating under the assumption this binary will either be removed or renamed some day.
Member
Author
There was a problem hiding this comment.
Good point. Let me add that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to hard-coded
ApplicationsVS Code install locations, on macOS also query Spotlight (the app search engine when you cmd-space) for all installs by searching with the command line toolmdfindfor the app's bundle identifier (com.microsoft.VSCodeorcom.microsoft.VSCodeInsiders).See also #80475 and #80479