Repository navigation
Standardize how Java8 is set in gradle files - #80600
Merged
Merged
Conversation
flutter-dashboard
Bot
added
a: accessibility
Contributor
|
Similar question as for @hamdikahloun's PR - this should really have a test that would otherwise fail, e.g. create a plugin, use some Java 1.8 feature in the source for it, and make sure it can compile. |
added 3 commits
April 16, 2021 17:18
Author
|
@dnfield Good point. Done |
dnfield
approved these changes
Apr 17, 2021
dnfield
left a comment
dnfield
left a comment
Contributor
There was a problem hiding this comment.
LGTM as long as tests are passing
21 of 22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is set from the plugin, but typically this is set from a user-defined gradle file.
This PR standardizes the way Java8 is set across the Gradle files. It also updates the template files for app, plugin and modules projects.
Fixes: #80442