Repository navigation
Update the docs for ProgressIndicator to remove some unnecessary adaptive descriptions. - #81427
Merged
darrenaustin merged 1 commit intoApr 28, 2021
Merged
Conversation
…tive descriptions.
flutter-dashboard
Bot
added
p: material_ui
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
HansMuller
approved these changes
Apr 28, 2021
HansMuller
left a comment
HansMuller
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Will need a no-tests exception from Ian - ask on the hackers channel is discord
Contributor
|
test-exempt: docs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The properties of
ProgressIndicatorwidgets that are ignored when using the adaptive version on cupertino platforms only apply to theCircularProgressIndicator.adaptive()method. Therefore we only need to mention this in the docs for that specific method and not on all the properties (especially when they are also used by the other progress indicators that don't have an adaptive version).Pre-launch Checklist
///).