Repository navigation
Migrate the navigator API to routeInformationUpdated. - #82594
Merged
Merged
Conversation
flutter-dashboard
Bot
added
the
framework
Hixie
force-pushed
the
nav
branch
2 times, most recently
from
May 17, 2021 22:22
1b18b00 to
b068dfc
Compare
Hixie
force-pushed
the
nav
branch
4 times, most recently
from
May 18, 2021 02:13
6b430b7 to
bf8184f
Compare
chunhtai
reviewed
May 18, 2021
chunhtai
left a comment
chunhtai
left a comment
Contributor
There was a problem hiding this comment.
I think we can call selectMultiEntryHistory in PlatformRouteInformationProvider.routerReportsNewRouteInformation?
Contributor
Author
|
Ok, added. |
Member
|
... but looks like some tests are failing... |
Hixie
force-pushed
the
nav
branch
2 times, most recently
from
May 20, 2021 04:13
a5392dc to
9cf4b45
Compare
Hixie
marked this pull request as ready for review
May 20, 2021 06:08
Contributor
Author
|
Blocked on flutter-team-archive/engine#26164 rolling into the framework. |
Instead of having two ways to update the engine about the current route, this moves everything to one API, and separately selects the single-entry history mode if you create a Navigator that reports routes. Also fixes flutter#82574
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having two ways to update the engine about the current route, this moves everything to one API, and separately selects the single-entry history mode if you create a Navigator that reports routes.
Also fixes #82574
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.