Skip to content

[flutter] use engine provided frame number - #82934

Merged
fluttergithubbot merged 2 commits into
flutter:masterfrom
jonahwilliams:use_frame_number
May 20, 2021
Merged

fluttergithubbot merged 2 commits into
flutter:masterfrom
jonahwilliams:use_frame_number

Conversation

@jonahwilliams

Copy link
Copy Markdown
Contributor

#80735

Use the engine frame number for Flutter.frame events

@flutter-dashboard flutter-dashboard Bot added the framework flutter/packages/flutter repository. See also f: labels. label May 19, 2021
@google-cla google-cla Bot added the cla: yes label May 19, 2021
@jonahwilliams
jonahwilliams requested a review from goderbauer May 19, 2021 20:00

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jonahwilliams

Copy link
Copy Markdown
Contributor Author

This is failing g3 tests because it isn't using the right engine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants